Zakariyah Ali <[email protected]> writes:
> Use C99 designated initializers (.type = T_ErrorSaveContext) instead of the
> standard initializer {T_ErrorSaveContext} when initializing ErrorSaveContext.
> This avoids missing-field-initializers compiler warnings for the remaining
> fields of
> the struct (e.g. error_occurred).
What compiler produces such warnings? I'm not really eager to make
invasive, more-typing-required changes like this, especially when
it's not obvious that the modified code is any more correct.
> Also fix a sign comparison warning in pg_dependencies_out() by changing
> the loop counter from int to uint32 to match dependencies->ndeps.
Same question --- I see no such complaints in our buildfarm.
regards, tom lane
