Hi

In commit 85c17f6, the variable old_catalog_xmin is using the type
XLogRecPtr, even though data.catalog_xmin is a TransactionId.

Attached patch fixes this by using TransactionId instead

Thanks
Imran Zaheer
From 601ffb1df94b3fabf69a99168bf42ab692c3be71 Mon Sep 17 00:00:00 2001
From: Imran Zaheer <[email protected]>
Date: Fri, 5 Jun 2026 13:58:48 +0500
Subject: [PATCH v1] Use correct type for catalog_xmin

Commit 85c17f6 introduced a variable storing catalog_xmin with type
XLogRecPtr, even though catalog_xmin is a TransactionId.

Use the correct type instead.
---
 src/backend/replication/logical/slotsync.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/replication/logical/slotsync.c b/src/backend/replication/logical/slotsync.c
index 93f41be32af..8cec8a49fb2 100644
--- a/src/backend/replication/logical/slotsync.c
+++ b/src/backend/replication/logical/slotsync.c
@@ -340,7 +340,7 @@ update_local_synced_slot(RemoteSlot *remote_slot, Oid remote_dbid)
 			bool		found_consistent_snapshot;
 			XLogRecPtr	old_confirmed_lsn = slot->data.confirmed_flush;
 			XLogRecPtr	old_restart_lsn = slot->data.restart_lsn;
-			XLogRecPtr	old_catalog_xmin = slot->data.catalog_xmin;
+			TransactionId	old_catalog_xmin = slot->data.catalog_xmin;
 
 			LogicalSlotAdvanceAndCheckSnapState(remote_slot->confirmed_lsn,
 												&found_consistent_snapshot);
-- 
2.34.1

Reply via email to