On Mon, Jun 8, 2026 at 10:36 PM Shlok Kyal <[email protected]> wrote: > > > Hi Ajin, > I have reviewed the patch and here are some comments: > > 1. I want to clarify, what is the expected behaviour when we upgrade > the postgres instance from version <= 16 to "HEAD + patch"? > - ReplicationOriginNameForLogicalRep(subid, InvalidOid, originname, > sizeof(originname)); > - replorigin_create(originname); > + if (!IsBinaryUpgrade) > + { > + ReplicationOriginNameForLogicalRep(subid, InvalidOid, > originname, sizeof(originname)); > + replorigin_create(originname); > + } > and > + /* Dump replication origins */ > + if (server_version >= 170000 && binary_upgrade && > archDumpFormat == archNull) > + dumpReplicationOrigins(conn); > > When the postgres instance with subscription is updated from PG 16 (or > less) to HEAD, the replication origin is created as we do not have "if > (!IsBinaryUpgrade)" check in HEAD, > whereas when the similar instance is upgraded to "HEAD + patch", no > replication origin is present after the upgrade. > Is this difference in the behaviour between HEAD and "HEAD + patch" expected? >
Good catch Shlok. IMO, the behaviour should be same even if we upgrade to HEAD+patch, it should not result in the loss of origins. thanks Shveta
