Oops, I forgot to attach the patch in my previous reply. Attaching v2 now. Best regards, shaobo zhang
shaobo zhang <[email protected]> 于2026年6月9日周二 14:41写道： > > Hi, > > Thank you for the review! > > You're right — this is a grammar-style cleanup rather than a fix, since > the existing code works fine without the semicolon. I've reworded the > commit message accordingly to make that clear, and attached it as v2. > > I'll add it to the CommitFest as you suggested so it can be picked up > after v20 opens. > > Best regards, > shaobo zhang > > Chao Li <[email protected]> 于2026年6月9日周二 13:52写道： > > > > > > > > > On Jun 5, 2026, at 15:01, shaobo zhang <[email protected]> wrote: > > > > > > The option_value grammar rule in src/pl/plpgsql/src/pl_gram.y was > > > missing a terminating semicolon, which is inconsistent with the style > > > used by other rules in the file. While Bison does not require > > > semicolons to terminate grammar rules, adding one here improves > > > consistency and readability. > > > <v1-0001-Fix-missing-semicolon-in-pl_gram.y-for-option_val.patch> > > > > I would not call this a “fix” as it doesn’t fix anything not working today. > > It is actually a grammar-style cleanup. Since the code being changed is 12 > > years old, I think this patch is a candidate for v20. > > > > Would you please add it to the CommitFest so that it can be noticed after > > v20 opens? > > > > Best regards, > > -- > > Chao Li (Evan) > > HighGo Software Co., Ltd. > > https://www.highgo.com/ > > > > > > > >
v2-0001-plpgsql-Add-missing-terminating-semicolon-to-opti.patch
Description: Binary data
