On 2026-06-17 We 5:59 PM, Noah Misch wrote:
On Mon, Jun 15, 2026 at 04:11:16PM -0400, Andrew Dunstan wrote:
On 2026-06-06 Sa 8:02 PM, Noah Misch wrote:
On Thu, Feb 26, 2026 at 09:02:48AM -0500, Andrew Dunstan wrote:
pushed with a slight tweak.
Having now reviewed commit 763aaa0, I don't think it's ready to remain part of
v19. While some points from my v18 review are now resolved, other points
still seem unresolved. I didn't find discussion of the unresolved points. I
also see new issues.
OK, here's a reversion path. It's a bit messy, and I didn't touch the
release notes, but apart from that I think it does the right thing.
I checked "git diff 763aaa06f03^ src/bin/pg_dump/{*.c,*.h,t}" and I agree this
reverts everything. Thanks for working through the revert.
Thanks for checking. Pushed with the release notes update.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
