Please find a few trivial comments on v13-001:
1)
check_publication_add_relation:
+ * 'pubrelkind' is the relkind accepted by the publication clause,
+ * while 'targetrelkind' is the relkind of the relation being added.
pubrelkind is the argument while targetrelkind is not. We generally
explain arguements here.
Can we rephrase to:
* 'pubrelkind' is the relkind accepted by the publication clause.
* The relkind of relation in given 'pri' is checked for compatibility
* against it. Error is emitted if they are not compatible.
2)
describePublications:
}
- else
+ if (puballtables)
{
Now since else is converted to independent 'if' block we can add a
blank line before it for better readability.
Same for this:
}
+ if (puballsequences)
+ {
3)
We have each test header like below starting from begining of file:
---------------------------------------------
-- Tests for inherited tables, and
-- EXCEPT clause tests for inherited tables
---------------------------------------------
---------------------------------------------
-- EXCEPT clause tests for partitioned tables
---------------------------------------------
So we can convert ours too in above format so that it is more visible:
+-- Test ALL SEQUENCES with EXCEPT clause
4)
We can add these tests to sql file:
a) SEQ keyword equivalent test to below table one:
-- fail - first table in the EXCEPT list should use TABLE keyword
CREATE PUBLICATION testpub_foralltables_excepttable2 FOR ALL TABLES
EXCEPT (testpub_tbl1, testpub_tbl2);
b) Try to add either of temporay or unlogged seq to except list.
thanks
Shveta
