Hello,
On 2026-Jun-26, Chao Li wrote:
> I didn’t take this part from your proposal, so an empty cell still shows
> nothing:
> ```
> @@ -442,7 +421,7 @@ printCrosstab(const PGresult *result,
> for (i = 0; i < cont.cellsadded; i++)
> {
> if (cont.cells[i] == NULL)
> - cont.cells[i] = "";
> + cont.cells[i] = printDisplayValue(&popt, InvalidOid,
> NULL, "");
> }
> ```
Yeah, this particular hunk wasn't intended for commit, so leaving it out
was the right thing to do.
> Your proposed test has NULL in the row and column headers, but not in
> the value column. I added a NULL value too, so the test case
> explicitly demonstrates the display difference between a NULL value
> and an empty cell.
Yeah, that's perfect, thanks.
> PFA v4: addressed Álvaro's comments.
Pushed now, thanks.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
