On 27.06.26 14:00, Peter Eisentraut wrote:
On 24.06.26 18:39, Paul A Jungwirth wrote:
On Wed, Jun 24, 2026 at 2:54 AM Peter Eisentraut
<[email protected]> wrote:
I have checked the patch v9 0002 "Move FOR PORTION OF volatile check
into planner". Functionality-wise, this seems correct.
Could you explain why you used EXPRKIND_TARGET? Maybe there is a good
reason, but otherwise it seems kind of arbitrary.
This expression is used in the target list to set the application-time
column. We intersect the old value with the FOR PORTION OF bounds.
The new ereport call in planner.c has some funny parentheses: You have
parentheses around errmsg, but not around errcode. This is probably
because of the way this was copy and pasted from its previous location.
Here are new patches with the parens cleaned up.
Ok, I have committed that v10 0002 patch. I will look at the other one
next.
Committed the 0001 patch as well. I added an errdetail that identifies
the name of the foreign table, which could be helpful when you're
dealing with a partition hierarchy.
