> On 27 Jun 2026, at 15:41, Andrey Borodin <[email protected]> wrote: > > I've done some > mechanical checks on the 18 variant A couple of minor things: - The new t/012_vm_consistency.pl needs pg_visibility, but src/bin/pg_combinebackup/Makefile doesn't declare EXTRA_INSTALL=contrib/pg_visibility, so a standalone "make -C src/bin/pg_combinebackup check" fails with "extension pg_visibility is not available". (meson test and make check-world are fine, since they install the whole tree) (for example see how src/bin/pg_amcheck pulls amcheck/pageinspect) - A tiny wording nit: the comment on the retained visibilitymap_clear() says it's kept "for backwards compatibility". Maybe spell out that it's kept for ABI(prototype stability) on the back branches? Best regards, Andrey Borodin.
- Re: Why clearing the VM doesn't require registering vm bu... Melanie Plageman
- Re: Why clearing the VM doesn't require registering ... Robert Haas
- Re: Why clearing the VM doesn't require register... Andrey Borodin
- Re: Why clearing the VM doesn't require regi... Andrey Borodin
- Re: Why clearing the VM doesn't require ... Melanie Plageman
- Re: Why clearing the VM doesn't require regi... Robert Haas
- Re: Why clearing the VM doesn't require ... Melanie Plageman
- Re: Why clearing the VM doesn't req... Melanie Plageman
- Re: Why clearing the VM doesn't... Melanie Plageman
- Re: Why clearing the VM doe... Fujii Masao
- Re: Why clearing the VM doe... Melanie Plageman
- Re: Why clearing the VM doe... Melanie Plageman
- Re: Why clearing the VM doe... Tom Lane
- Re: Why clearing the VM doe... Melanie Plageman
