On Wed, 1 Jul 2026 at 08:17, Peter Smith <[email protected]> wrote:
>
> A review comment for patch v5-0001
>
> ======
> doc/src/sgml/ref/pg_createsubscriber.sgml
>
> 1.
> +   replica from a physical standby server.  By default,
> +   <application>pg_createsubscriber</application> configures
> +   <link linkend="logical-replication">logical replication</link> by
> +   automatically creating internal publication and subscription objects. In
> +   this mode, a publication and subscription are created for each database, 
> and
> +   the publications include all tables and sequences in their respective
> +   databases. When user-specified publications are used, the subscriptions
> +   replicate only the objects included in those publications. It must be run 
> at
> +   the target server.
>
> In that last sentence, I felt it might be better to avoid saying "It"
> which could be misunderstood as referring to something other than the
> tool itself.
>
> BEFORE
> It must be run at the target server.
> SUGGESTION
> <application>pg_createsubscriber</application> must be run at the target 
> server.

The attached v6 version patch has the changes for the same.

Regards,
Vignesh

Attachment: v6-0001-Include-sequences-in-publications-created-by-pg_c.patch
Description: Binary data

Reply via email to