On Wed, Jul 01, 2026 at 03:52:51PM +0800, Ewan Young wrote: > If reviewers would rather push the ErrorSaveContext down into > numerictypmodin() (or a shared helper) > instead of pre-validating in the caller, I'm happy to reshape it that way.
My first impression while looking at your patch and the surroundings of numeric.c is that we should do exactly that, and feed from the error message received from the new function to which an escontext is given. That would save in extra error messages (why not just reuse the same errstrings in this case?), and we could rely on error_occurred for the detection. -- Michael
signature.asc
Description: PGP signature
