Use PG_MODULE_MAGIC_EXT macro in modules added in PG19

[Andreas Karlsson]

Hi,

It looks like we forgot about the PG_MODULE_MAGIC_EXT macro when adding 
pg_plan_advice, pg_stash_advice and pgrepack so here is a patch fixing that.

Maybe we should also use the new macro in other places like our test 
modules and our modules in the documentation and the tutorial but there 
I am less certain and that is a separate topic.

--
Andreas Karlsson
Percona
From 66fc5ece7305e698deb25f674067f2d0f05c0843 Mon Sep 17 00:00:00 2001
From: Andreas Karlsson <andr...@proxel.se>
Date: Thu, 2 Jul 2026 23:47:32 +0200
Subject: [PATCH v1] Use PG_MODULE_MAGIC_EXT in newly introduced modules

We forgot to use the PG_MODULE_MAGIC_EXT in some newly added modules:
pg_plan_advice, pg_stash_advice and the pgrepack output plugin and
instead used the older PG_MODULE_MAGIC macro. Let's consistently use
PG_MODULE_MAGIC_EXT in all our modules.
---
 contrib/pg_plan_advice/pg_plan_advice.c     | 5 ++++-
 contrib/pg_stash_advice/pg_stash_advice.c   | 5 ++++-
 src/backend/replication/pgrepack/pgrepack.c | 5 ++++-
 3 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/contrib/pg_plan_advice/pg_plan_advice.c b/contrib/pg_plan_advice/pg_plan_advice.c
index 299b0d02a86..7cd753ee171 100644
--- a/contrib/pg_plan_advice/pg_plan_advice.c
+++ b/contrib/pg_plan_advice/pg_plan_advice.c
@@ -28,7 +28,10 @@
 #include "storage/dsm_registry.h"
 #include "utils/guc.h"
 
-PG_MODULE_MAGIC;
+PG_MODULE_MAGIC_EXT(
+					.name = "pg_plan_advice",
+					.version = PG_VERSION
+);
 
 /* GUC variables */
 char	   *pg_plan_advice_advice = NULL;
diff --git a/contrib/pg_stash_advice/pg_stash_advice.c b/contrib/pg_stash_advice/pg_stash_advice.c
index 1858c6a135a..777ff374599 100644
--- a/contrib/pg_stash_advice/pg_stash_advice.c
+++ b/contrib/pg_stash_advice/pg_stash_advice.c
@@ -22,7 +22,10 @@
 #include "utils/guc.h"
 #include "utils/memutils.h"
 
-PG_MODULE_MAGIC;
+PG_MODULE_MAGIC_EXT(
+					.name = "pg_stash_advice",
+					.version = PG_VERSION
+);
 
 /* Shared memory hash table parameters */
 static dshash_parameters pgsa_stash_dshash_parameters = {
diff --git a/src/backend/replication/pgrepack/pgrepack.c b/src/backend/replication/pgrepack/pgrepack.c
index 959551f5724..5c5095bde4e 100644
--- a/src/backend/replication/pgrepack/pgrepack.c
+++ b/src/backend/replication/pgrepack/pgrepack.c
@@ -18,7 +18,10 @@
 #include "replication/snapbuild.h"
 #include "utils/memutils.h"
 
-PG_MODULE_MAGIC;
+PG_MODULE_MAGIC_EXT(
+					.name = "pgrepack",
+					.version = PG_VERSION
+);
 
 static void repack_startup(LogicalDecodingContext *ctx,
 						   OutputPluginOptions *opt, bool is_init);
-- 
2.43.0