On Thu, Jul 16, 2026 at 01:38:00PM -0700, Jacob Champion wrote:
> On Wed, Jul 15, 2026 at 2:57 PM Bruce Momjian <[email protected]> wrote:
> > You can see the updated output here:
> >
> > https://momjian.us/pgsql_docs/release-19.html
>
> Thanks! I think one of those patches partially undid the other one; see below.
>
> > Let me know if there should be anymore changes?
>
> I've definitely kept you waiting long enough. See attached suggestions
> for my entries.
>
> First patch adjusts credit, expands/rewords some items [1], and
> rewrites the new authdata hook section to hopefully better illustrate
> why it belongs to libpq. Let me know what you think.
>
> Second patch should just be motion, I hope: the pg_hba changes go into
> the server config section and the authdata hook goes into libpq. It
> also deprioritizes the PQgetThreadLock() section, which I imagine very
> few people will care about in practice. :D
Patch applied.
> I think this replays some of what Andreas was hoping for, maybe with
> more context. I'm not sure why "Allow OAuth validators to supply
> failure details" is still with server configuration at the moment,
> based on the conversation above, so maybe that also needs to be moved
> back to Source Code. I didn't do that here, in case it was on purpose.
I am confused by this item. I moved it to Source Code in commit
aa9787e325d, but then moved it again in commit 0546889b1b9. I have
moved it back to Source Code as you suggested.
> (I don't know if it's been discussed somewhere, but I find that the
> standard Git diff algorithm can't handle these sorts of doc-motion
> patches in a readable way. The attached patches were generated with
> `git format-patch --histogram` instead.)
I am very glad you mentioned this. I have been traveling for two weeks,
and tried to get the original patch applied several times. I would
study the patch, and the things wrong with the patch, and then get
confused. I thought I was losing my ability to analyze patches or
something. Combining the fact I don't understand how all the Oauth
features fit together with the problems of understanding a patch with no
context really overwhelmed me, plus I am trying to fit it into a travel
schedule.
The current output is at:
https://momjian.us/pgsql_docs/release-19.html
Please let me know if there should be some more changes.
--
Bruce Momjian <[email protected]> https://momjian.us
EDB https://enterprisedb.com
Do not let urgent matters crowd out time for investment in the future.
