On 16.07.26 17:35, Paul A Jungwirth wrote:
On Wed, Jul 15, 2026 at 6:10 PM Chao Li <[email protected]> wrote:
Actually, when I received v4, I was also working on addressing Dean’s comments.
I reviewed both v4 and v5, made some small adjustments, and here is v6:
* For the create_policy doc change, I changed “check new row” to “check
leftover rows”.
* For the “SELECT rights” comment, I moved it into the block comment, because
its position in v5 looked like a placeholder.
* For the tests, v4 and v5 added the new cases in the MERGE section. I added
the test in a more direct section.
* For the tests, v4 and v5 granted INSERT privilege. V6 intentionally does not,
because the test runs UPDATE/DELETE FOR PORTION OF, and INSERT privilege is not
required for inserting leftover rows by design.
I took a look. These all seem like improvements to me.
committed v6