Hi David, On 2018/10/05 21:55, David Rowley wrote: > On 17 September 2018 at 21:15, David Rowley > <david.row...@2ndquadrant.com> wrote: >> v9 patch attached. Fixes conflict with 6b78231d. > > v10 patch attached. Fixes conflict with cc2905e9.
Thanks for rebasing. > I'm not so sure we need to zero the partition_tuple_slots[] array at > all since we always set a value there is there's a corresponding map > stored. I considered pulling that out, but in the end, I didn't as I > saw some Asserts checking it's been properly set by checking the > element != NULL in nodeModifyTable.c and copy.c. Perhaps I should > have just gotten rid of those Asserts along with the palloc0 and > subsequent memset after the expansion of the array. I'm undecided. Maybe it's a good thing that it's doing the same thing as with the child_to_parent_maps array, which is to zero-init it when allocated. Thanks, Amit
