Hi, On 2026-07-22 09:06:44 -0400, Nathan Bossart wrote: > On Wed, Jul 22, 2026 at 02:31:49PM +0200, Peter Eisentraut wrote: > > Here is an instance that seems obviously wrong: > > > > /* Buffer id of the buffer that Startup process waits for pin on, or -1 > > */ > > - int startupBufferPinWaitBufId; > > + pg_atomic_uint32 startupBufferPinWaitBufId; > > I may just be undercaffeinated, but what is wrong with this case? AFAICT > the casting should work as expected, and I see other examples that do > something similar, like avLauncherProc.
The comment says -1, which doesn't really make sense for an unsigned variable. Greetings, Andres Freund
