On Mon, Jul 27, 2026 at 10:10 PM Masahiko Sawada <[email protected]> wrote: > > Agreed and pushed the 0001 patch. > > I've updated the comments in the previous-0002 patch, please review it. >
In the comments you mentioned 'already-visible slot' as follows: "Our already-visible slot guarantees that this check doesn't miss ..." but we normally don't use visibility term for slots (it is used primarily for tuples). I think you mean to say that its in_use flag is set, I tried to slightly modify that part of the comment in the attached. See, if that looks okay to you. Apart from that, I ran the added test on my Windows machine and it failed, attached find the required log. -- With Regards, Amit Kapila.
v4_topup_comment-fixup.patch
Description: Binary data
051_effective_wal_level_standby5.log
Description: Binary data
regress_log_051_effective_wal_level
Description: Binary data
