On Fri, Jul 31, 2026 at 1:18 PM Shlok Kyal <[email protected]> wrote: > > > Attached v24 patch set. > > > Hi Nisha, > > While addressing comments for one of my patches, I took a quick look > at patch 0004 (the documentation patch). I have a few comments:
Thanks Shlok for the review > 1. While building documenttation, I find following error: > /usr/bin/xmllint --nonet --path . --path . --output postgres-full.xml > --noent --valid postgres.sgml > /usr/bin/xsltproc --nonet --path . --path . --stringparam pg.version > '20devel' stylesheet.xsl postgres-full.xml > ERROR: id attribute missing on <varlistentry> element under /book[@id > = 'postgres']/part[@id = 'reference']/reference[@id = > 'sql-commands']/refentry[@id = > 'sql-alterpublication']/refsect1/variablelist > no result for postgres-full.xml > make: *** [Makefile:130: html-stamp] Error 10 > > I think we need to define a id attribute here: > + <varlistentry> > + <term><literal>EXCEPT</literal></term> > + <listitem> > Fixed in v25. > 2. Should we add 'clause' after <literal>EXCEPT</literal> ? > + SCHEMA</literal>, the exclusion applies only to tables in the schema > + associated with the <literal>EXCEPT</literal>. > Makes sense, updated in v25. > 3. Maybe we can simplify the below: > + <structname>sales.drafts</structname>. Other than > + <structname>sales.drafts</structname>, any previously excluded > tables for schema > + <structname>sales</structname> are no longer excluded. Any schemas > previously in > > Maybe change: > Other than <structname>sales.drafts</structname>, any previously excluded > tables > for schema <structname>sales</structname> are no longer excluded. > to: > All other previously excluded tables in schema <structname>sales</structname> > are no longer excluded. > I'm okay with suggestion. Updated in v25. -- Thanks, Nisha
