On Thu, 30 Jul 2026 at 18:21, Aleksander Alekseev <[email protected]> wrote:
> Hi Rafia, > > > I looked into this patch and have a few comments. > > Firstly, in test_create_custom_scan_state() why hard coding css.slotOps > = &TTSOpsBufferHeapTuple and not using the table_slot_callbacks() for the > purpose and getting the real AM. > > Next, in test_plan_custom_path, the last two arguments are never used. > > There are no tests for nodeCopy, nodeEqual, nodeOut, and nodeRead > routines. > > Many thanks for the feedback! Here is the corrected patch. > > Thanks. There is a typo in the current patch --... the CustomScanStateand and is expected Other than that it looks good to me. -- Regards, Rafia Sabih CYBERTEC PostgreSQL International GmbH
