> > PSA patch v2. > Hi, Created a v3 and issued the following topics I found.
- Fixed typo in CREATE SUBSCRIPTION block: max_rentention_duration → max_retention_duration (was causing the TailMatches check to never fire for that option) - Applied pgindent to clean up indentation in the ALTER PUBLICATION and ALTER SUBSCRIPTION SET blocks (reproduces the same fix pattern identified in v1 review) While reviewing, I noticed you applied the "(*)" idiom to ALTER PUBLICATION/SUBSCRIPTION SET blocks (great fix), but the CREATE PUBLICATION/SUBSCRIPTION blocks still use the seen_with scan. For consistency, the same pattern could be applied there too. What is your opinion about it? Please see the attached v3.
v3-0001-psql-tab-completion-of-pub-sub-options.patch
Description: Binary data
