Hi, While reading the aggregation-related executor code, I noticed a comment that no longer matches what the code does.
In BuildTupleHashTable() (src/backend/executor/execGrouping.c) we have:
hashtable->tableslot = NULL; /* will be made on first lookup */
The slot is no longer made on first lookup. Commit bf6c614a2f2 removed
the lazy creation from LookupTupleHashEntry() and made
BuildTupleHashTable() create the slot unconditionally, further down in
the same function. Only the comment and its assignment were left behind.
The attached patch removes both. Nothing reads tableslot before
slot is actually created.
Regards,
Tatsuya Kawata
v1-0001-Remove-stale-comment-and-dead-store-in-BuildTuple.patch
Description: Binary data
