On Mon, Jun 8, 2026 at 7:24 PM Amit Kapila <[email protected]> wrote: > > On Wed, Jun 3, 2026 at 11:35 AM Ewan Young <[email protected]> wrote: > > > > On Wed, Jun 3, 2026 at 1:10 PM Peter Smith <[email protected]> wrote: > > > > > > Here is a patch to reword 2 publication error messages: > > > > > > BEFORE/AFTER > > > "relation \"%s\" is already member of publication \"%s\"", > > > "relation \"%s\" is already a member of publication \"%s\"", > > > > > > BEFORE/AFTER > > > "schema \"%s\" is already member of publication \"%s\"", > > > "schema \"%s\" is already a member of publication \"%s\"", > > > > > > ~~~ > > > > > > All other 'member of' error messages in PostgreSQL source are using > > > correct grammar ('a member of'), so IMO these should do likewise. > > > > > > PSA v1. > > > > Thanks. Patch applies cleanly on master, the wording fix matches all other > > 'member of' messages in the tree, and make check passes (245/245). LGTM. > > > > LGTM as well. I think it is a minor inconsistency and we should fix it > only in HEAD. If so, we can probably wait for the PG20 branch to open > as this is not newly introduced in PG19. >
I also think it only needs to be fixed in HEAD. And, the PG20 branch started ages ago, so AFAIK there are no blockers for this patch anymore. ====== Kind Regards, Peter Smith. Fujitsu Australia
