Re: GIN pageinspect support for entry tree and posting tree

[Japin Li]

Hi Kirill

Thanks for updating the patches.

On Mon, 03 Aug 2026 at 17:40, Kirill Reshke <reshkekir...@gmail.com> wrote:
> Hi all,
>
> I have rebased patches and did little polishing for error
> messages/overall style. Posting to see how new CI reacts & also bump
> thread.
>

Commit c456e391138 introduced an assertion 
Assert(tupleDesc->firstNonCachedOffsetAttr >= 0)
in nocache_index_getattr() to guarantee that TupleDescFinalize() has been 
invoked prior.
Patch v20260308-0002 overlooked this in gin_entrypage_items(), here is the 
trivial fix:


diff --git a/contrib/pageinspect/ginfuncs.c b/contrib/pageinspect/ginfuncs.c
index 8433ee507b6..b50807a251e 100644
--- a/contrib/pageinspect/ginfuncs.c
+++ b/contrib/pageinspect/ginfuncs.c
@@ -324,6 +324,8 @@ gin_entrypage_items(PG_FUNCTION_ARGS)
                        TupleDescInitEntryCollation(tmpTupdesc, (AttrNumber) 2,
                                                                                
attr->attcollation);
 
+                       TupleDescFinalize(tmpTupdesc);
+
                        attrVal = index_getattr(idxtuple, 
OffsetNumberNext(FirstOffsetNumber),
                                                                        
tmpTupdesc,
                                                                        
&isnull);
>
> -- 
> Best regards,
> Kirill Reshke

-- 
Regards,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.