> Can we combine the two tests into a single 010_backup.pl to keep cluster
> inits down?

I reworked the tests with another injection point as part of this,
this way they shouldn't be flaky on CI and they are significantly
faster now.

> I'm not sure that "since the server started" is enough for a backup taken from
> a standby. XLogCtl is zeroed at startup, while the checksum state is restored
> from pg_control. The standby can become available before replay reaches the
> latest checksum transition, so verification could resume with
> lastChecksumChangeRecPtr invalid.

There was really an issue there, I think we can solve that by
advancing minrecoverypoint. I kept a test case for this separate for
now, as I am unsure if we want to include it in some form.

> I think that an atomic would make more sense.

Also done.

Attachment: v3-0001-basebackup-do-not-verify-checksums-on-pages-from-.patch
Description: Binary data

Reply via email to