Hello Daniel,

28.08.2026 22:07, Daniel Gustafsson пишет:
I'll have a go at reproducing the error when I am back in the office, but off
the cuff I would expect the below to fix it.  The state transition to off
didn't wait for completion which can lead to that timing error in reading back
the state.

-disable_data_checksums($node);
+disable_data_checksums($node, wait => 1);

Yes, this change makes the test pass (50 iterations) reliably for me.

Thank you for paying attention to it!

Interesting, I'll have a closer look when back but test 15 in that file doesn't
test for off at all so the reference to 15 in the above must be a red herring?
Which test was it according to the not ok line in the log?

It's the same case 3:
[07:31:26.623](0.102s) not ok 3 - ensure checksums are set to off on 
injection_node
[07:31:26.630](0.008s)
[07:31:26.630](0.000s) #   Failed test 'ensure checksums are set to off on 
injection_node'
#   at 
/pgtest/postgresql.git/src/test/modules/test_checksums/t/DataChecksums/Utils.pm 
line 69.
[07:31:26.631](0.000s) #          got: 'inprogress-on'
#     expected: 'off'
....
[07:31:37.327](0.002s) # Looks like you failed 1 test of 17.


Best regards,
Alexander


Reply via email to