The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation: tested, passed
So,the patch applied cleanly to master branch(basically,i cut a branch and applied the patch), builds without issues, and passes the regression tests. Since,this was my first time reviewing a code in particular, learning from this how buffer-only reads bypass WALRead() and why closing the open segment file descriptor is required to avoid stale descriptors across WAL segment boundaries was a great insight into how WAL reading works. overall,it looks good
