On Tue, Sep 1, 2026 at 10:59 AM Peter Eisentraut <[email protected]> wrote: > These can be caught if we dial up the warning one notch to > -Wshadow=local. This then flags all shadowing of a local variable by > another local variable. I have fixed all the warnings in the attached > patch. I think everything this catches is obviously bad, so this seems > well worth fixing. (And if we buy into the idea of > -Wshadow=compatible-local, then this is obviously better and more complete.)
+1 to fixing all of these, and to using -Wshadow=compatible-local. -- Peter Geoghegan
