Hi Nazir,

Thank you for the review.

> 'meson test --list' doesn't guarantee the order of the returned
> list, so we might miss tests if the order differs between tasks.

Agreed.  Since the two runners build their lists independently, a
different order could produce both a missing test and a duplicate.  V2
sorts the names before applying the round-robin selection.

> I think we can save this step as something like
> 'upload_logs_step_slice' and use it in the Windows VS task as well.

Agreed.  V2 defines the slice-aware upload step in the Linux job and
reuses it for the existing Windows Visual Studio matrix.  This also
avoids the existing artifact-name collision when both Windows slices
fail.

I also tried splitting MinGW.  In six recent full runs the unsliced job
took 28:36-31:29 and was the slowest job each time.  The two slices
completed in 15:05 and 17:32, so v2 includes this too.

PFA v2.


Best regards, Andrey Borodin.

Attachment: v2-0001-Split-Linux-ASAN-and-MinGW-tests-across-runners.patch
Description: Binary data

Reply via email to