Please avoid top-posting replies, it makes it difficult to get the context of what you're replying to.
On Wed, 9 Sept 2026 at 07:23, Clemenza Zhang <[email protected]> wrote: > So I have not found any new correctness issue in these tests. > > One possible test-coverage suggestion: the current indexing regression > test checks that relfilenode changes after ADD COLUMN, ALTER TYPE, and > DROP COLUMN. It might be worth also checking the result of an actual > lookup through the rebuilt expression index, since stale index contents > were the user-visible failure mode of the original bug. As I mentioned upthread, I think it's sufficient to check that the index was rebuilt, because there are no signs that the index insertion's expression evaluation code itself is broken for whole-row expressions, and because index rebuilds use a tablescan for the new index data and not the old data of the index being rebuilt. > Likewise, since v4 adds OBJECT_WHOLE_ROW specifically to address the > object-address issue, the table whole-row round-trip case might be > worth adding to the object-address regression tests. Attached version 5 includes updated object_address.sql tests. Kind regards, Matthias van de Meent Databricks (https://www.databricks.com)
v5-0001-Track-whole-row-Var-dependencies-in-pg_depend.patch
Description: Binary data
