On Thu, Sep 10, 2026 at 7:52 PM Ajin Cherian <[email protected]> wrote: > ... > Thanks for the updated match with the fixes and the new tests. The fix > works and the new tests are welcome. A few minor comments: > > 1. > + for (int i = 0; i < num_schemas; i++) > + { > + const char *nspname = PQgetvalue(res, i, 0); > + > + describeOneSchemaDetails(nspname, verbose); > + } > + } > > The return value (bool) of describeOneSchemaDetails is ignored. Is it > even required? >
The return was there to mirror the other describeOneXXX functions, but
I neglected to check it. Now handling the result, similar to other
functions.
> 2.
> The code now allocates memory for title as well but is not freed in
> the error path.
>
> + initPQExpBuffer(&title);
> + printfPQExpBuffer(&title, _("Schema \"%s\""), schemaname);
>
Fixed.
PSA patch v6.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
v6-0001-Fix-escapes-for-psql-describe-schema-patterns.patch
Description: Binary data
