On Fri, 18 Sept 2026 at 18:25, Amit Kapila <[email protected]> wrote:
>
> Also, shall we keep just one test, say Drop Index Concurrently instead
> of two as both tests do the same thing in a slightly different way? I
> have not done that but if you agree please update the patch
> accordingly.
I also felt one test should be fine.
The patch mostly looks good. I have one small comment: the tests use a
different ordering for wakeup and detach. If we retain the second
test, we could keep the ordering consistent.
+ # Release the worker. The index it holds is no longer the identity.
+ $node_subscriber->safe_psql(
+ 'postgres',
+ "SELECT
injection_points_wakeup('apply-update-before-open-indices');
+ SELECT
injection_points_detach('apply-update-before-open-indices');"
+ );
+ $node_subscriber->safe_psql(
+ 'postgres',
+ "SELECT
injection_points_detach('apply-update-before-open-indices');
+ SELECT
injection_points_wakeup('apply-update-before-open-indices');"
+ );
Regards,
Vignesh
