Re: REPACK (CONCURRENTLY) loses missing values of columns added without a rewrite

[shihao zhong]

Hi Sami,

v2 fixes the issue you mentioned.

I think It also fixes another case. If the added column is in the replica
identity index, REPACK looks up the row with a NULL key. That fails the
Assert in find_target_tuple(), or gives "could not find target tuple"
without assertions. Adding this to the test covers it:

    CREATE UNIQUE INDEX repack_test_i_c_idx ON repack_test (i, c);
    ALTER TABLE repack_test REPLICA IDENTITY USING INDEX
repack_test_i_c_idx;

Thanks,
Shihao