> I found a caller in pg_lake [0] that creates its own EState without > setting es_snapshot. It pushes an active snapshot, but passes the > unchanged EState to ExecCheckIndexConstraints(). Your proposed > InvalidSnapshot guard would cover this too.
Maybe we should open a bug report to pg_lake about this? Even if we allow for this here, the documentation still requires es_snapshot to be set. I attached v2 based on Dean's suggestion, if we want to go that route. I would still be leaning towards including both code changes instead (or if we do not want that, adjusting the documentation about this), but for now this is a simple alternative patch that only relaxes the original fix when we use es_snapshot.
v2-0001-Fix-crash-in-logical-replication-apply-worker-at-.patch
Description: Binary data
