On Mon, Oct 5, 2026 at 5:39 AM Hunaid Sohail <[email protected]> wrote: > On Sun, Oct 4, 2026 at 12:54 AM Kacper Kuras <[email protected]> wrote: >> >> I think most of this comes from matching names as strings (with >> RangeVars from qualified_name_list). BCN-036R1 says the entries in >> the exclude list should be resolved the same way as column >> references in the select list. So perhaps each entry could be >> transformed as an ordinary ColumnRef, and the star expansion could >> then skip the columns whose Var matches, without modifying the >> namespace item. That would give error positions and correct handling >> of aliases and schemas for free. > > Thanks for reviewing the patch and reporting bugs. I already switched to > ColumnRef in the upcoming patch since I also found similar kinds of issues. > These issues would hopefully be fixed in the new version. >
+1 for the review work and the framing here after such a long time away. One thing that wasn't always clear (and hopefully the spec will answer this better) is that while select t2.* exclude (bar) from t2; should be supported, it isn't really clear that select (t2).* exclude (bar) from t2; shouldn't just throw an error. >> >> Hunaid, are you planning to post a v3 with the standard syntax? I'd >> be glad to test it. > > Sorry for the delay, I was busy with some other important stuff during > this period. v3 is around the corner that includes support for new > standard syntax with REPLACE and RENAME clauses. > No worries, I think a lot of folks are still focused on v19 related items. Perhaps related, I suspect this might be easier to get in for v20 if the patches work incrementally; ie. EXCLUDE first, then worry about REPLACE and RENAME clauses. Granted that depends on the general complexity of adding those in. Robert Treat https://xzilla.net
