On Fri, Oct 9, 2026 at 4:08 AM Dilip Kumar <[email protected]> wrote: > > On Fri, Oct 9, 2026 at 2:51 AM Amit Kapila <[email protected]> wrote: > > > > Okay, I see the problem but I wonder why you didn't consider using > > rd_opcintype stored in index relation to solve this problem. I have > > tried the attached atop v79-0001 and v79-0002, manually executed the > > test you shared in this email and it fixed the issue for me. > > Yeah you can do that, but if we directly fetch the heap attribute and > then value from the slot like I have done in my 0003 patch you can get > rid of all the processing done inside build_index_datums_from_slot() > i.e. calling FormIndexDatum(BuildIndexInfo) etc. If you see my patch > with that I am able to remove all this extra processing, I am sure we > can get rid of that by some other way as well but I think thats the > most obvious way of doing it. >
I was looking from the code consistency point of view. We already used this idea in build_index_value_desc() code path while reporting the conflict in LOG, so it looks natural to use the same idea here. Also, as this is a path where conflict already happened and we decided to insert into conflict_history_table, so the performance will anyway be not the main concern, so we can consider this optimization separately. -- With Regards, Amit Kapila.
