Sorry for not being active in the thread, I am at pgconf.eu this week +# cannot SET ROLE to. With run_as_owner = false (the default), synchronizing +# regress_s4 will fail when switching to its owner. ... + ALTER SEQUENCE regress_s1 OWNER TO regress_seq_sub_owner; + ALTER SEQUENCE regress_s3 OWNER TO regress_seq_sub_owner; + ALTER SEQUENCE "regress'quote" OWNER TO regress_seq_sub_owner; + ALTER SEQUENCE regress_s4 OWNER TO regress_seq_other; + ALTER SUBSCRIPTION regress_seq_sub OWNER TO regress_seq_sub_owner; + ALTER SUBSCRIPTION regress_seq_sub ENABLE;
I see that the current consensus seems to be that we do not fix the stall, only improve the error reporting. Same thing in the commit message: > the error message does not > identify which sequence or subscription triggered the failure. We should at least mention that the stall is also there, and that it is intentionally not fixed. Even in this case, I think it would be worth to keep the test similar to the original and: * give second or third sequence to someobody else, not the last * Assert that not even the first one gets ready if we have one stall, with a comment explaining the decision Otherwise this will likely generate more bugreports later, as the current comment understates the issue.
