On Tue, Oct 20, 2026 at 4:31 PM Jim Jones <[email protected]> wrote: > > rebase
Hi Jim and all, I tested the v28 patch for adding the xmlcanonicalize() function and wanted to share my findings. While building the patch, I encountered a compilation error in the xml_parse() call because one argument was missing. I added the missing argument locally, after which the build completed successfully. I then tested the main functionality: -XML attributes were sorted into canonical order. -Empty elements were converted into explicit opening and closing tags. -Equivalent XML documents produced the same canonical output. -Comments were preserved by default and removed when keep_comments was set to false. -NULL input returned NULL. All regression tests passed on my locally corrected version. I also ran git diff --check, which completed without warnings after I corrected the indentation. Could you please check the xml_parse() call and update the patch accordingly? Thanks for your work on this! Regards, solai
