On Sat, Oct 31, 2026 at 10:17 AM shihao zhong <[email protected]> wrote: > > Thanks for the fix! All six LOG callers pass the entry the search used. > > Two things: > > 1. The new comment says relmapentry is NULL when no search was done. > But update_exists also passes NULL, and it did search. >
AFAICS, to report update_exists, we call CheckAndReportConflict() which always passes NULL in ReportApplyConflict(). Can you point us to the code you are referring to? > 2. Get_tuple_desc() still calls GetRelationIdentityOrPK(), so with > conflict_log_destination = 'all' the log and the table can disagree. > This is a pre-existing wart which we can fix separately after this patch as it would be easier to do so. I intentionally left it because as noted in comments this is a pre-existing issue though a minor one but if you or others feels we should fix it along with this patch then we can do so, but I prefer to do it separately. BTW, do you have any opinion on 0002 related to the two_phase option? -- With Regards, Amit Kapila.
