Hi Daniel & Zsolt,

Thanks for working on this. This is my first time review oauth related
patches, and I hope my understanding is correct here, if not, please
correct me.

I tried v2 and the login still works.  v1 checked the return value of
check_oauth_validator(), but v2 drops that.

COMMERROR only logs, and nothing checks the return value.
With the list set to '' and reloaded, I can still log in and run queries:

  LOG:  parameter "oauth_validator_libraries" must be set ...
  LOG:  connection authenticated: identity="test" method=oauth

The attached patch on top of v2 fails the login when the check fails.

Thanks,
Shihao

Attachment: nocfbot-v2-0002-Reject-the-login-when-the-validator-is-no-longer-all.patch
Description: Binary data

Reply via email to