Hi,
On Tue, Nov10, 2026 at 01:35 AM vignesh C wrote:
Thanks for the comments, the updated v9 version patch has the changes
to fix the same. The other comment regarding stale comments from [1]
also is addressed in this version. [1] -
https://www.postgresql.org/message-id/CAFiTN-sKca5sRc1xVL9ghdYT%3DhKtzoNoKMVwbrE1G55J0pdC9A%40mail.gmail.com
Thanks for updating the patch.
I have two minor comments:
1. It looks unnecessary to change this comment:
/*
- * The actual error must have been reported by the parallel
- * apply worker.
+ * The parallel apply worker did error-out, the leader apply
+ * worker must exit as well.
*/
2. Since we removed this local variable, the '{' also becomes removable,
as we normally avoid adding it under case condition when no local
variable is declared.
{
- ErrorData edata;
-
- /* Parse ErrorResponse. */
- pq_parse_errornotice(msg, &edata);
The other part looks good to me.
--
Best Regards,
Zhijie Hou
