Hi,

I started to study the thread. Here are minor comments for 0002.
I understood the refactoring must be done master-only.

01.
```
+static Buffer
+hash_xlog_lock_bucket(XLogReaderState *record, uint8 block_id, Size rec_size)
```

I think the function name is too general. IIUC the function intends to lock a
primary page, but it's not described in the function name. How about renaming to
"hash_xlog_lock_primary_bucket" or similar?

02.
```
+               /* block 0 is absent if the primary bucket page is not modified 
*/
```

I felt this comment can be more friendly like:

```
                /*
                 * If the primary bucket page is modified, it is registered as 
block 0
                 * and read for REDO.  Otherwise, acquire its cleanup lock 
separately.
                 */
```

Best regards,
Hayato Kuroda
FUJITSU LIMITED

Reply via email to