Hi Greg, Thank you for the v7 patch and the new recovery test.
I tested v7 on a local build. While running 061_hash_vacuum_insert_crc on Linux (ext4, meson build), subtest 2 failed for me with: pg_waldump: error: invalid WAL segment size in WAL file "000000010000000000000002" (0 bytes) Both LSNs are in segment ...0001, and segment ...0002 is a zero-filled 16 MB file. When --path is a directory, pg_waldump seems to read the segment size from the first WAL file readdir() returns, so the result depends on directory order (here 0002 came first). Passing the segment file for $start_lsn (for example from pg_walfile_name) worked for me by hand. Subtest 3 passed and I saw no CRC problem. I did not apply the change to the test and rerun it under meson. Thanks again! Regards, Joao Rito
