Hi Richard
> > > I disagree. This function doesn't free any of its other bitmapsets, > > so I'm not sure where you get that conclusion. Freeing just this one > > would look odd. Also, I don't see the point: this one small bitmapset > > has no real impact on memory usage, and it will be cleaned up along > > with the planner's memory context anyway. > > Sorry for the noise — I misremembered how remove_useless_groupby_columns() > handles its bitmapsets. You're right, there's no need to free > nullable_relids here. > > Thanks
