Hi,

On Fri, Nov 13, 2026 at 10:18:34PM -0800, Masahiko Sawada wrote:
> I think the root cause is that commit 788ec96d591 replaced
> found_consistent_snapshot with the check of slotsync_skip_reason, but
> they're not equivalent: found_consistent_snapshot is false unless the
> current cycle synced the slot and found a consistent snapshot, whereas
> slotsync_skip_reason is SS_SKIP_NONE unless the current cycle detected
> a reason to skip. So an alternative idea would be to bring back
> found_consistent_snapshot part from the commit. That way, the decision
> of persisting the slot doesn't depend on the skip_reasons at all.

Yeah, that makes sense to me.

> I've attached a PoC patch.

Thanks! Will look at it early next week.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com


Reply via email to