Hi Melanie,

Thanks for v3 and for adding the all-frozen check.

v3 looks good.

A few small comments:
1. In 0002, tablecmds.c already includes catalog/pg_am.h, which exports
catalog/pg_am_d.h, so the added #include "catalog/pg_am_d.h" is redundant.

2. For the back-branch wrapper of CreateAndCopyRelationData(), I'd
suggest it pass false for the main fork. For an unknown caller that is
always correct, the all-zeroes check still keeps the saving
whenever the hole is actually zero, and the non-main forks are handled
correctly either way.

Regards,
Surya Poondla

Reply via email to