Hi Zsolt, Thanks for your review, I appreciate it.
> With this restriction master can't create divergent partitions > anymore, and pg_upgrade refuses them, so is d8444163d still needed on > master after this patch? 19 still needs it. A 19 cluster may already have such partitions, and a minor update does not run pg_upgrade. > 1. Explicit vs implicit cast v5 compares the deparsed text, which is what pg_dump writes. > 2. ONLY with a detach-pending partition The recursive SET EXPRESSION skipped those partitions too. ONLY now counts them as children. Without ONLY, the command asks to finish the detach first. > ddl.sgml, a few lines below the paragraph fixed. > Plain inheritance has the same wrong results, both on master and with > the patch: v5 applies the same rule to plain inheritance, so your cc example now fails at CREATE TABLE. pg_upgrade refuses such children too. I also found CREATE TABLE ... (LIKE ...) INHERITS skips these checks. I think it needs to have its own thread. Thanks, Shihao
nocfbot-v5-REL_18-0001-Require-child-tables-to-use-the-parent-s-virtual-gen.patch
Description: Binary data
v5-0001-Require-child-tables-to-use-the-parent-s-virtual-gen.patch
Description: Binary data
