Hi

There's more to fix here.  I think the rule to complete using
Query_for_list_of_concurrent_indexables after "CONCURRENTLY ON" is
obsolete, and worse, it is bogus.  First, it is obsolete because if you
have a REPACK command, it will complete nonsense:

  REPACK (CONCURRENTLY ON <tab>
shows a list of tables/schemas.  Useless!

Second, bogus; the claim is that you need to use TailMatches() because
the CREATE INDEX command can appear as part of a CREATE SCHEMA.  But
that doesn't actually work:

=# create schema foo create table bar (a int) create index concurrently on bar 
(a);
ERROR:  CREATE INDEX CONCURRENTLY cannot be executed from a function or 
procedure

so trying to provide completions after
TailMatches(CONCURRENTLY MatchAny ON) or TailMatches(CONCURRENTLY ON)
is something that we need to remove, not patch.

Thanks, regards,

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Debido a que la velocidad de la luz es mucho mayor que la del sonido,
 algunas personas nos parecen brillantes un minuto antes
 de escuchar las pelotudeces que dicen." (Roberto Fontanarrosa)


Reply via email to