On 20/06/2026 13:45, Álvaro Herrera wrote:
On 2026-Jun-20, Michael Paquier wrote:
When using -DMEMORY_CONTEXT_CHECKING, (also enforced by
-DUSE_VALGRIND), I am getting a couple of compiler warnings when
building without assertions:

All these ought to be marked with a PG_USED_FOR_ASSERTS_ONLY.  Not
sure why nobody has seen that yet?  I am using a gcc 16.1.1, nothing
fancy AFAIK.

I saw this a few days ago too when testing for f50c329f538f, when
enabling MEMORY_CONTEXT_CHECKING independently (without USE_VALGRIND and
without USE_ASSERTIONS), and in that case, I even saw a compile failure
in bump.c.  That requires a messier, uglier patch than what you have
here.  I staged something but I thought it warranted more polish before
posting.  I don't have it in this computer ATM sadly.

Committed Michael's patch for now. Not sure what that bigger issue with compilation failure that you mentioned is, but this fix seemed pretty straightforward.

- Heikki



Reply via email to