On 11/20/26 00:07, Fujii Masao wrote:
> On Fri, Nov 20, 2026 at 3:29 AM Tomas Vondra <[email protected]> wrote:
>> I ended up committing it too.
> 
> Thanks for working on this!
> 
> The new test fails on some buildfarm members, such as indri on v17 [1].
> It sets maintenance_io_concurrency = 1, but v17 and earlier reject
> nonzero values on platforms without posix_fadvise(), causing the standby
> to fail to start.
> 
> In v18, this restriction was removed for AIO support, so the setting is
> accepted, although recovery prefetching remains disabled on these platforms.
> 
> Should we skip the test when recovery prefetching is unavailable?
> 

D'oh! I completely forgot about this. Yes, we should skip the test for
these machines. I'll look into that tomorrow morning (unless you want to
take care of it).

What's a good way to check if a machine supports posix_fadvise? I don't
see any TAP test already doing that. I guess we could try assigning into
effective_io_concurrency, and skip the test if it fails.


regards

-- 
Tomas Vondra



Reply via email to