Hi Andrew, > The test module has two AMs that copy heap's routine, one without the > callback. heap_getnext() insists on heap's own routine, so their tables can > have no index or TOAST table; the test shows one refused and the other past > the check.
A small comment for the patch: The REPACK(CONCURRENTLY) statements failed the wal-level checking with wal_level=mininal in my testing. This seems to be the cause of 4b2aa4b39cb to move concurrent REPACK tests out of cluster.sql. Does it make sense to follow pg_walinspect and set wal_level = replica in a temp config for make and meson? -- Regards, Xuneng Zhou HighGo Software Co., Ltd.
